-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add product custom fields documentation #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments that can help improve the documentation a little bit.
Thanks for your hands on this @octaedro
Thank you @mdperez86 for the review. I just addressed your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my suggestions! I left one more comment related to the parameters that the endpoint receives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameters were updated correctly.
The documentation looks good.
Nice job @octaedro !
Changes proposed in this Pull Request:
The WooCommerce PR woocommerce/woocommerce#48504 added a new REST API endpoint meant to get the
product custom field
names.Closes woocommerce/woocommerce#46921
This PR adds the documentation necessary for that new endpoint.
How to test the changes in this Pull Request:
build
folder in your project.build
folder and open the file./index.html
in your browser.Product custom fields
in the sidebar.