Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

featured_src is not read-only in current released API version #28

Closed

Conversation

theinventor
Copy link

In our testing we noticed we are able to use this field, and it's the correct way to set a featured image at this time.

Am I putting this in the right place?

@claudiosanches
Copy link
Contributor

@theinventor I'll check it later. thanks.

@claudiosanches
Copy link
Contributor

I just checked, for v2 is read-only.

@theinventor
Copy link
Author

@claudiosmweb is current woocommerce versioned 2.5 using the v2 api or the v3?

In the current live version we are able to set this field.

The documentation is wrong

@claudiosanches
Copy link
Contributor

It's read-only on v2 and v3 using WooCommerce 2.5.

See by yourself:

https://github.com/woothemes/woocommerce/blob/master/includes/api/class-wc-api-products.php#L1146

Only in one place it is possible to find featured_src... And where we are seeing is just the view/read context.

@claudiosanches
Copy link
Contributor

In the current live version we are able to set this field.

Show me how.

@theinventor
Copy link
Author

@claudiosmweb Ok, what we saw is when we apply a bunch of images - there is no featured image. When we set that field, a featured image is there.

I don't actually care enough to burden myself further - I was just trying to be helpful in pointing this out.

@claudiosanches
Copy link
Contributor

@theinventor

Ok, what we saw is when we apply a bunch of images - there is no featured image. When we set that field, a featured image is there.

Impossible, because we do not use in absolutely nowhere when saving products or images.

This can only be happening if you are using a plugin that doing it for you.

I don't actually care enough to burden myself further - I was just trying to be helpful in pointing this out.

This does not really help, since I'm saying it is not used to save images and you can not help me understand what is happening for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants