Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy WBTC market on Mainnet #102

Open
wants to merge 65 commits into
base: main
Choose a base branch
from
Open

Deploy WBTC market on Mainnet #102

wants to merge 65 commits into from

Conversation

MishaShWoof
Copy link
Collaborator

No description provided.

MishaShWoof and others added 30 commits August 9, 2024 23:45
@MishaShWoof
feat: create comet with extended asset list
bba7d99
@MishaShWoof
feat: move new cometExt to its own contract
fc16ae0
@MishaShWoof
fix: clean up
6b62ee6
@MishaShWoof
fix: gas optimization
d06a3f6
@MishaShWoof
fix: more gas optimization
d2873ad
@MishaShWoof
fix: linter fix
5e867a0
@MishaShWoof
fix: natspec
8ab1786
@MishaShWoof
fix: more natspec
171eb7a
@MishaShWoof
Update index.ts
53f1513
@MishaShWoof
fix: remove unused iterface
8df38e6
@MishaShWoof
feat: add prepare and enact for simulation
70e8a73
@MishaShWoof
fix: fix to workflow
4c0a8f4
@MishaShWoof
Update enact-migration.yaml
c29f4b9
@MishaShWoof
fix: reverse
cf08c19
@MishaShWoof
feat: add prepare and enact workflow
71fee7b
@dmitriy-woof-software
feat: update enact migration script
57d04f7
@dmitriy-woof-software
feat: update enact migration script
f0c33a1
@dmitriy-woof-software
feat: update enact migration script
df2d152
@dmitriy-woof-software
feat: update enact migration script
92937aa
@MishaShWoof
fix: remove verification from simulatative migration
b72092c
@MishaShWoof
Merge branch 'main' of github.com:woof-software/comet into woof-softw…
ea15450 
…are/collateral-extension
@MishaShWoof
feat: fixes after audit
dfe98c9
@MishaShWoof
fix: working tests
4f2ba04
@MishaShWoof
fix: no network issue resolved
e641f95
@MishaShWoof
Merge branch 'main' into woof-software/collateral-extension
986efa2
@MishaShWoof
fix: audit fixes
5c75787
@MishaShWoof
fix
4e41a94
@MishaShWoof
Merge branch 'woof-software/fix-to-no-network' of github.com:woof-sof…
547e934 
…tware/comet into woof-software/collateral-extension
@MishaShWoof
feat: working scenarios
6635049
@MishaShWoof
feat: migrations and working scenarios
4ba3b92
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 21, 2025
View reviewed changes
contracts/AssetList.sol
Comment on lines +75 to +103
constructor(CometConfiguration.AssetConfig[] memory assetConfigs) {
uint8 _numAssets = uint8(assetConfigs.length);
numAssets = _numAssets;

(asset00_a, asset00_b) = getPackedAssetInternal(assetConfigs, 0);
(asset01_a, asset01_b) = getPackedAssetInternal(assetConfigs, 1);
(asset02_a, asset02_b) = getPackedAssetInternal(assetConfigs, 2);
(asset03_a, asset03_b) = getPackedAssetInternal(assetConfigs, 3);
(asset04_a, asset04_b) = getPackedAssetInternal(assetConfigs, 4);
(asset05_a, asset05_b) = getPackedAssetInternal(assetConfigs, 5);
(asset06_a, asset06_b) = getPackedAssetInternal(assetConfigs, 6);
(asset07_a, asset07_b) = getPackedAssetInternal(assetConfigs, 7);
(asset08_a, asset08_b) = getPackedAssetInternal(assetConfigs, 8);
(asset09_a, asset09_b) = getPackedAssetInternal(assetConfigs, 9);
(asset10_a, asset10_b) = getPackedAssetInternal(assetConfigs, 10);
(asset11_a, asset11_b) = getPackedAssetInternal(assetConfigs, 11);
(asset12_a, asset12_b) = getPackedAssetInternal(assetConfigs, 12);
(asset13_a, asset13_b) = getPackedAssetInternal(assetConfigs, 13);
(asset14_a, asset14_b) = getPackedAssetInternal(assetConfigs, 14);
(asset15_a, asset15_b) = getPackedAssetInternal(assetConfigs, 15);
(asset16_a, asset16_b) = getPackedAssetInternal(assetConfigs, 16);
(asset17_a, asset17_b) = getPackedAssetInternal(assetConfigs, 17);
(asset18_a, asset18_b) = getPackedAssetInternal(assetConfigs, 18);
(asset19_a, asset19_b) = getPackedAssetInternal(assetConfigs, 19);
(asset20_a, asset20_b) = getPackedAssetInternal(assetConfigs, 20);
(asset21_a, asset21_b) = getPackedAssetInternal(assetConfigs, 21);
(asset22_a, asset22_b) = getPackedAssetInternal(assetConfigs, 22);
(asset23_a, asset23_b) = getPackedAssetInternal(assetConfigs, 23);
}

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: compound.solidity.missing-constructor-sanity-checks

There're no sanity checks for the constructor argument assetConfigs.
contracts/AssetList.sol
Comment on lines +75 to +103
constructor(CometConfiguration.AssetConfig[] memory assetConfigs) {
uint8 _numAssets = uint8(assetConfigs.length);
numAssets = _numAssets;

(asset00_a, asset00_b) = getPackedAssetInternal(assetConfigs, 0);
(asset01_a, asset01_b) = getPackedAssetInternal(assetConfigs, 1);
(asset02_a, asset02_b) = getPackedAssetInternal(assetConfigs, 2);
(asset03_a, asset03_b) = getPackedAssetInternal(assetConfigs, 3);
(asset04_a, asset04_b) = getPackedAssetInternal(assetConfigs, 4);
(asset05_a, asset05_b) = getPackedAssetInternal(assetConfigs, 5);
(asset06_a, asset06_b) = getPackedAssetInternal(assetConfigs, 6);
(asset07_a, asset07_b) = getPackedAssetInternal(assetConfigs, 7);
(asset08_a, asset08_b) = getPackedAssetInternal(assetConfigs, 8);
(asset09_a, asset09_b) = getPackedAssetInternal(assetConfigs, 9);
(asset10_a, asset10_b) = getPackedAssetInternal(assetConfigs, 10);
(asset11_a, asset11_b) = getPackedAssetInternal(assetConfigs, 11);
(asset12_a, asset12_b) = getPackedAssetInternal(assetConfigs, 12);
(asset13_a, asset13_b) = getPackedAssetInternal(assetConfigs, 13);
(asset14_a, asset14_b) = getPackedAssetInternal(assetConfigs, 14);
(asset15_a, asset15_b) = getPackedAssetInternal(assetConfigs, 15);
(asset16_a, asset16_b) = getPackedAssetInternal(assetConfigs, 16);
(asset17_a, asset17_b) = getPackedAssetInternal(assetConfigs, 17);
(asset18_a, asset18_b) = getPackedAssetInternal(assetConfigs, 18);
(asset19_a, asset19_b) = getPackedAssetInternal(assetConfigs, 19);
(asset20_a, asset20_b) = getPackedAssetInternal(assetConfigs, 20);
(asset21_a, asset21_b) = getPackedAssetInternal(assetConfigs, 21);
(asset22_a, asset22_b) = getPackedAssetInternal(assetConfigs, 22);
(asset23_a, asset23_b) = getPackedAssetInternal(assetConfigs, 23);
}

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.non-payable-constructor

Consider making costructor payable to save gas.
contracts/CometWithExtendedAssetList.sol

uint startGas = gasleft();
accrueInternal();
for (uint i = 0; i < accounts.length; ) {

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.array-length-outside-loop

Caching the array length outside a loop saves reading it on each iteration, as long as the array's length is not changed during the loop.
contracts/CometWithExtendedAssetList.sol
accrueInternal();
for (uint i = 0; i < accounts.length; ) {
absorbInternal(absorber, accounts[i]);
unchecked { i++; }

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-prefix-increment-not-postfix

Consider using the prefix increment expression whenever the return value is not needed. The prefix increment expression is cheaper in terms of gas.
contracts/CometWithExtendedAssetList.sol
// Using gas price instead of base fee would more accurately reflect spend,
// but is also subject to abuse if refunds were to be given automatically.
LiquidatorPoints memory points = liquidatorPoints[absorber];
points.numAbsorbs++;

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-prefix-increment-not-postfix

Consider using the prefix increment expression whenever the return value is not needed. The prefix increment expression is cheaper in terms of gas.
contracts/CometWithExtendedAssetList.sol
uint8 _reserved = accountUser._reserved;

uint256 basePrice = getPrice(baseTokenPriceFeed);
uint256 deltaValue = 0;

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.init-variables-with-default-value

Uninitialized variables are assigned with the types default value. Explicitly initializing a variable with its default value costs unnecessary gas.
contracts/CometWithExtendedAssetList.sol

emit AbsorbCollateral(absorber, account, asset, seizeAmount, value);
}
unchecked { i++; }

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-prefix-increment-not-postfix

Consider using the prefix increment expression whenever the return value is not needed. The prefix increment expression is cheaper in terms of gas.
contracts/CometWithExtendedAssetList.sol
if (isBuyPaused()) revert Paused();

int reserves = getReserves();
if (reserves >= 0 && uint(reserves) >= targetReserves) revert NotForSale();

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if

Using nested is cheaper than using && multiple check combinations. There are more advantages, such as easier to read code and better coverage reports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MishaShWoof @dmitriy-woof-software