✨ list blocked users and unblock #451
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
HaiSeong
approved these changes
Feb 10, 2025
Comment on lines
96
to
99
| @GetMapping("/block/list") | ||
| public List<UserBlockResponse> getBlockees(@LoginUser UserInfo userInfo) { | ||
| return userService.getBlockeesOf(userInfo.getId()); | ||
| } |
There was a problem hiding this comment.
REST api에 가까운 설계는
GET user/me/block 또는 GET user/me/block/list 가 아닐까 생각합니다. (저희가 복수형을 사용했으면 더 자연스러웠을것 같아요 GET users/me/blocks)
uri가 자원의 위치를 나타내야 하는데 위치를 잘 나타내지 못한다는 생각을 했습니다.
아토의 의견 궁금합니다
There was a problem hiding this comment.
지금보니 blockUser도 비슷한 느낌이 드는것 같아요.
수요일에 같이 논의 할 수 있으면 좋겠어요!
| @@ -85,8 +84,26 @@ public UserBlockResponse blockUser(long blockerId, long blockeeId) { | |||
|
|
|||
| UserBlock userBlock = userBlockRepository.save(new UserBlock(blocker, blockee)); | |||
|
|
|||
| return new UserBlockResponse(new UserResponse(userBlock.getBlocker()), | |||
| new UserResponse(userBlock.getBlockee())); | |||
| return new UserBlockResponse(userBlock); | |||
tackyu
approved these changes
Feb 12, 2025
Comment on lines
+169
to
+173
| assertAll( | ||
| () -> assertThat(actual).isEqualTo(expected), | ||
| () -> assertThat(userBlockRepository.existsByBlockerIdAndBlockeeId(1L, 2L)).isTrue() | ||
|
|
||
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
차단을 해제하고, 차단 목록을 불러옵니다!
더 고려해야 하는 예외가 있는지 한 번씩 검토 부탁드립니다~~~
closes #450