-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for radare2 #104
base: main
Are you sure you want to change the base?
Conversation
… addNames.r2 script see merge request worawit#67
hey @worawit can you merge this in? lots of people use Radare2, not IDA Pro. |
before merging i want to cleanup some code but having a feedback on this will would be good |
of << std::format("f app.base = {:#x}\n", app.base()); | ||
of << std::format("f app.heap_base = {:#x}\n", app.heap_base()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are un-necessary since they change with every run and aren't constant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but its good to have some as reference, but yeah i was trying to expose some pointers for later testing and see if those are useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what would be nice is to know where the object pool is located. aka the address of PP. because right now r2 bases it to address 0, but its configurable. and blutter can be specifying that address
hey @worawit can you merge this pr? lots of people use Radare2, not IDA Pro. Including me and all termux users. |
7855ea0
to
6c65845
Compare
try again, should be good now |
This comment was marked as resolved.
This comment was marked as resolved.
You are not using latest commit rebuild again pls |
Ah, yes, thank you for pointing that out. I missed it, but after testing it now, it works perfectly. Awesome, thank you! |
- by @truefae worawit#104 - revert base & heap_base comment - needs latest r2 from git
hey @worawit can you merge this pr? lots of people use Radare2, not IDA Pro. Including me and all termux users. |
Should be good to merge now |
This branch is rebased on top of the current master, but picks the code from #67, as well as the fixes introduced by @cryptax in #88 and extends the logic to also flag all the constant pool data, there are few more fixes to be done in r2 to get all the string references to work without depending on the blutter analysis.
Note that this PR also includes the build fix from #103 otherwise it was failing to compile.
I have also patches for the Dockerfile that i submitted half a year ago but as long as nothing was merged, i'm quite tempted to just contribute to the @AbhiTheModder fork instead.