Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gherkin lint action #268

Closed
wants to merge 1 commit into from
Closed

Add Gherkin lint action #268

wants to merge 1 commit into from

Conversation

ernilambar
Copy link
Member

No description provided.

@swissspidy
Copy link
Member

Seems to work 👍 GitHub Actions annotations would be a bonus, but not a requirement.

This would be something for https://github.com/wp-cli/.github

@swissspidy
Copy link
Member

GitHub Actions annotations would be a bonus, but not a requirement.

It might be doable with a custom problem matcher https://fusectore.dev/2021/11/19/github-action-problem-matchers.html

@ernilambar
Copy link
Member Author

@swissspidy

Where should the lint-gherkin.yml and .gherkin-lintrc files reside? https://github.com/wp-cli/.github/ ?
Should we implement like reusable-XXX.yml?

@swissspidy
Copy link
Member

The Gherkin lint job should be part of the existing reusable-code-quality.yml file in the .github repository.

Do we need a custom .gherkin-lintrc? If so, we could try finding a way to have that in the .github repo as well. Otherwise we would need to copy to file to all of our repos, which is not great for maintenance.

@ernilambar
Copy link
Member Author

Yes, .gherkin-lintrc is required as linter use rules mentioned in that file. I agree it should be placed somewhere in the central repo so that each command repo wont need it.

@swissspidy
Copy link
Member

Then we put it in the .github repo and temporarily download it like you are already doing in this step here.

I would just download it to $RUNNER_TEMP

@ernilambar
Copy link
Member Author

Completed in wp-cli/.github#127

@ernilambar ernilambar closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants