Skip to content

Cache certain GitHub URLs #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 5, 2025
Merged

Cache certain GitHub URLs #385

merged 13 commits into from
May 5, 2025

Conversation

pfefferle
Copy link
Contributor

Cache GitHub URLs, where we can extract the plugin/theme name and the version number.

this fixes #363

@pfefferle pfefferle requested a review from a team as a code owner November 16, 2023 16:53
@pfefferle pfefferle marked this pull request as draft November 16, 2023 16:54
@danielbachhuber
Copy link
Member

@pfefferle Are you still planning to finish this up?

@pfefferle
Copy link
Contributor Author

Sure, but I thought it might be good to wait for #386 to be merged to see if I can re-use some of its functionality?!?

@swissspidy
Copy link
Member

#386 was ultimately merged via #421, so I suppose this could now be revisited.

Let us know if you'd like some help with it :)

@swissspidy swissspidy marked this pull request as ready for review April 30, 2025 19:50
@swissspidy
Copy link
Member

@schlessera wanna review it too since you added it to #6086?

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/WP_CLI/CommandWithUpgrade.php 71.42% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy added this to the 2.1.24 milestone May 1, 2025
@schlessera schlessera merged commit 110989e into wp-cli:main May 5, 2025
42 of 43 checks passed
@schlessera
Copy link
Member

Thanks for your work on this, @pfefferle !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache wp plugin install from GitHub
4 participants