Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"isSession" field added to the "UpdateCustomerInput" type #924

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented Feb 25, 2025

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

Implements a "isSession" field for the updateCustomer mutation, when set to true, the changes made to the end-user's won't persist to the database and will instead be saved on the customer object stored in the end-user's session data. One major reason to utilize this is for shipping rate calculations where product to be shipped could be going somewhere other than the end-user's primary shipping address on file in the database.

Fixes #889

Example

updateCustomer(input: {
  isSession: true,
  shipping: {
    ...
  }
}) {
  ...
}

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shipping rate is not updating when signed in
1 participant