Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #7248 Preconnect to external domains - Data insertion part #7310

Merged

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Feb 17, 2025

Description

Add database structure for preconnect external domains

Fixes #7248

Type of change

  • New feature (non-breaking change which adds functionality).

Detailed scenario

N/A

Technical description

Documentation

Add database queries, schema, ajax controller for preconnect external domains features.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Copy link

codacy-production bot commented Feb 17, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for fc03b071 52.94% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fc03b07) Report Missing Report Missing Report Missing
Head commit (fb9dbf1) 39349 17162 43.61%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7310) 102 54 52.94%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Khadreal Khadreal self-assigned this Feb 17, 2025
@Khadreal Khadreal changed the base branch from feature/preconnect-external-domains to feature/7246-beacon-insertion-part February 17, 2025 17:57
@Khadreal Khadreal linked an issue Feb 18, 2025 that may be closed by this pull request
@Khadreal Khadreal marked this pull request as ready for review February 18, 2025 14:13
@Khadreal Khadreal requested a review from a team February 18, 2025 14:13
@MathieuLamiot
Copy link
Contributor

@Khadreal the CI is failing
If this needs another PR to fix the test, please write it down here so we can know what needs to be done.

@Khadreal Khadreal changed the title Feature/7248 data insertion part Closes #7248 Preconnect to external domains - Data insertion part Feb 18, 2025
@Khadreal Khadreal changed the base branch from feature/7246-beacon-insertion-part to feature/preconnect-external-domains February 19, 2025 08:48
# Conflicts:
#	inc/Engine/Media/PreconnectExternalDomains/ServiceProvider.php
# Conflicts:
#	inc/Engine/Common/PerformanceHints/Activation/ServiceProvider.php
#	inc/Engine/Common/PerformanceHints/ServiceProvider.php
#	inc/Engine/Media/PreconnectExternalDomains/Factory.php
#	inc/Engine/Media/PreconnectExternalDomains/ServiceProvider.php
@Khadreal Khadreal force-pushed the feature/7248-data-insertion-part branch from 5e4bfd7 to b693ee1 Compare February 19, 2025 09:27
@Khadreal Khadreal requested a review from Miraeld February 19, 2025 18:03
Copy link
Contributor

@wordpressfan wordpressfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table is created successfully, good job @Khadreal

@Khadreal Khadreal merged commit 3a030ae into feature/preconnect-external-domains Feb 20, 2025
11 checks passed
@Khadreal Khadreal deleted the feature/7248-data-insertion-part branch February 20, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.19 - Preconnect to external domains - Data insertion part
4 participants