Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Closes #7243: preload fonts frontend rockethead #7320

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Feb 21, 2025

Description

Fixes #7243

This PR brings the front-end optimization to the newly added feature Preload Fonts.

Type of change

  • New feature (non-breaking change which adds functionality).

Detailed scenario

This uses new head structure to insert preload items into head.

Technical description

Documentation

n/a

New dependencies

n/a

Risks

n/a

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

If some mandatory items are not relevant, explain why in this section.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@Miraeld Miraeld force-pushed the feature/7243-preload-fonts-frontend branch from 33d0397 to 9474498 Compare February 21, 2025 15:36
…preload-fonts-frontend-rockethead

# Conflicts:
#	inc/Engine/Media/PreloadFonts/Frontend/Controller.php
#	tests/Fixtures/inc/Engine/Common/PerformanceHints/Frontend/Subscriber/maybe_apply_optimizations.php
Copy link

codacy-production bot commented Feb 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.04% (target: -0.10%) 66.67% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (daa4504) 39468 17265 43.74%
Head commit (915fa84) 39474 (+6) 17285 (+20) 43.79% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7320) 39 26 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@wordpressfan wordpressfan merged commit a412b60 into feature/7243-preload-fonts-frontend Feb 22, 2025
11 of 14 checks passed
@wordpressfan wordpressfan deleted the feature/7243-preload-fonts-frontend-rockethead branch February 22, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants