This repository has been archived by the owner on Apr 2, 2020. It is now read-only.
Remove PHP 5.3 from Travis matrix, add PHP7.1 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis no longer supports testing against pre-installed PHP5.3, and we don't have to either. Updating the build matric so new tests can pass (see #78 (comment))
Some very basic code cleanup so that the build can pass again on Travis.
|
Would love a second set of eyes on this before I merge. It's mostly just coding style and tests fixes, but as it's been a while since I've been in this codebase, I'd like a second set of eyes to confirm I'm not breaking anything. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis no longer supports testing against pre-installed PHP5.3, and we
don't have to either. Updating the build matrix so new tests can pass
(see #78 (comment))