-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wpimath] Add vector slewrate limiter #7806
base: main
Are you sure you want to change the base?
Conversation
Co-Authored-By: Tyler Veness <[email protected]>
Co-authored-by: Tyler Veness <[email protected]>
Co-authored-by: Tyler Veness <[email protected]>
I can see I have some work to do on this. Will mark as ready for review when I resolve all the current feedback |
Co-authored-by: Tyler Veness <[email protected]>
Co-authored-by: Tyler Veness <[email protected]>
Does using allwpilib/wpimath/src/main/native/include/units/base.h Lines 2153 to 2162 in f9307de
Oopsies on my part for forgetting that the unit operations need to be grouped together so that the |
Co-authored-by: Tyler Veness <[email protected]>
Co-authored-by: Tyler Veness <[email protected]>
Co-authored-by: Tyler Veness <[email protected]>
Co-authored-by: Tyler Veness <[email protected]>
You'll need to add |
builds on my machine fine now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just one tiny nitpick that I noticed. (The last 5% of the work always takes the longest, but I think you're nearly there)
Co-authored-by: Joseph Eng <[email protected]>
Co-authored-by: Joseph Eng <[email protected]>
Intends to close #4708
Adds a function in MathUtil which takes an initial Translation(2d or 3d), and a second translation, the time interval between them and a max velocity. The function will return the output translation, which is the translation with the capped speed(if the speed of the translation is less than the maxVelocity, then the translation should be unchanged).
will mark PR as ready for review when java code is completed