[wpiutil] Add usage reporting API - #9339
Merged
PeterJohnson merged 4 commits intoAug 25, 2026
Merged
Conversation
github-actions
Bot
added
component: wpiutil
calcmogul
previously approved these changes
Aug 23, 2026
PeterJohnson
force-pushed
the
wpiutil-usage-reporting
branch
from
August 23, 2026 18:10
c849366 to
1c3d40b
Compare
calcmogul
previously approved these changes
Aug 23, 2026
Similar to other things, this is connected to the HAL backend during robot construction. This reduces the need for the Shared shims for individual components.
PeterJohnson
force-pushed
the
wpiutil-usage-reporting
branch
from
August 25, 2026 00:35
1c3d40b to
a9bb6a6
Compare
zachwaffle4
approved these changes
Aug 25, 2026
auscompgeek
reviewed
Aug 25, 2026
|
|
||
| def _start(self, robot_cls: wpilib.RobotBase) -> bool: | ||
| hal.report_usage("Language", "Python") | ||
| wpiutil.set_report_usage_impl(hal.report_usage) |
Member
There was a problem hiding this comment.
This forces usage reporting calls to go back through the Python interpreter. This would result in the GIL being released then soon after locked again on object construction. Are we okay with this overhead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to other things, this is connected to the HAL backend during robot construction.
This reduces the need for the Shared shims for individual components.