Unscope all create or update queries #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we shouldn't use a default scope anyways i think. And make a published scope and use where needed. Much more descriptive and you dont need to use |
| @@ -41,7 +41,7 @@ def create_or_update(wp_type, wp_id, preview = false) | |||
| # WP API will return a code if the route is incorrect or | |||
| # the specified entry is none existant. If so return early. | |||
| return if wp_json[0] and invalid_api_responses.include? wp_json[0]["code"] | |||
| where(wp_id: wp_id).first_or_initialize.update_wp_cache(wp_json) | |||
| unscoped.where(wp_id: wp_id).first_or_initialize.update_wp_cache(wp_json) | |||
There was a problem hiding this comment.
We should DRY this up a bit 🍶
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a default scope on our model, which filters out non published posts. This resulted in WpCache.create_or_update trying to insert the same (unpublished) wp_id multiple times because
where(wp_id: wp_id)didn't return this unpublished post.