Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional View Access For Discoverable Applications in MyAccount #439

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

DilshanSenarath
Copy link

@DilshanSenarath DilshanSenarath commented Jan 27, 2025

Purpose

This update will implement the necessary service layer changes for discoverable applications based on the groups assigned to the application in sub organizations.

  • Modify the service layer logic for resolving discoverable apps for a user in a sub-organization.

Related Issue

@@ -449,6 +471,48 @@ private List<ApplicationBasicInfo> getDiscoverableSharedApplicationBasicInfo(int
return Collections.unmodifiableList(applicationBasicInfoList);
}

/**
* Retrieve the group IDs list of the logged in user.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment to describe this

List<SharedApplicationDO> sharedApplications =
orgApplicationMgtDAO.getSharedApplications(ROOT_APP_ID, ROOT_ORG_ID, sharedOrgIds);
orgApplicationMgtDAO.getSharedApplications(rootAppUUID, SUPER_ORG_ID, sharedOrgIds);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename SUPER to ROOT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant