Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set username as the default subject identifier #311

Open
wants to merge 2 commits into
base: 3.0.0
Choose a base branch
from

Conversation

Akila94
Copy link
Member

@Akila94 Akila94 commented Feb 3, 2025

Set username as the default subject identifier

  • This PR makes the SP property useUserIdForDefaultSubject as false to make username the default subject identifier across IS 6.0.0 and IS 6.1.0. This property is not used when the OB solution is deployed on IS 5.11.0.

Issue link: #289

Doc Issue: : Needs to remove the steps mentioned in the documentation to add the subject claim URL.

Applicable Labels: OB3 Accelerator


Development Checklist

  1. Built complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verify the PR does't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Documented test scenarios(link available in guides).
  3. Written automation tests (link available in guides).
  4. Verified tests in multiple database environments (if applicable).
  5. Verified tests in multiple deployed specifications (if applicable).
  6. Tested with OBBI enabled (if applicable).
  7. Tested with specification regulatory conformance suites (if applicable).

Automation Test Details

Test Suite Test Script IDs
Integration Suite TCXXXXX, TCXXXX

Conformance Tests Details

Test Suite Name Test Suite Version Scenarios Result
Security Suite VX.X Foo, Bar Passed

Resources

Knowledge Base: https://sites.google.com/wso2.com/open-banking/

Guides: https://sites.google.com/wso2.com/open-banking/developer-guides

@Akila94 Akila94 force-pushed the add-username-subject-id branch from 966f3a9 to 447956d Compare February 6, 2025 08:54
@Akila94 Akila94 force-pushed the add-username-subject-id branch from 447956d to 2f437c3 Compare February 13, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants