Skip to content

Disable XML property override #2395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2025
Merged

Disable XML property override #2395

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0aad21
Disable XML property override
GDLMadushanka Sep 18, 2025
f8369cf
Merge branch 'master' into fixPayloadFactory
GDLMadushanka Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions modules/core/src/main/java/org/apache/synapse/SynapseConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,4 @@ public enum ENDPOINT_TIMEOUT_TYPE { ENDPOINT_TIMEOUT, GLOBAL_TIMEOUT, HTTP_CONNE

public static final String DEFAULT_ERROR_TYPE = "ANY";
public static final String ERROR_STATS_REPORTED = "ERROR_STATS_REPORTED";
public static final String ENABLE_DTD_FORCEFULLY = "payloadFactory.forcefully.enable.DTD";
public static final String ENABLE_EXTERNAL_ENTITY_FORCEFULLY
= "payloadFactory.forcefully.enable.external.entity";
}
1 change: 0 additions & 1 deletion ...les/core/src/main/java/org/apache/synapse/mediators/transform/PayloadFactoryMediator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import org.apache.axiom.om.OMText;
import org.apache.axiom.om.impl.builder.StAXBuilder;
import org.apache.axiom.om.impl.builder.StAXOMBuilder;
import org.apache.axiom.om.util.StAXUtils;
import org.apache.axiom.soap.SOAP11Constants;
import org.apache.axiom.soap.SOAP12Constants;
import org.apache.axiom.soap.SOAPEnvelope;
Expand Down
12 changes: 0 additions & 12 deletions .../core/src/main/java/org/apache/synapse/mediators/transform/pfutils/TemplateProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.synapse.MessageContext;
import org.apache.synapse.SynapseConstants;
import org.apache.synapse.SynapseException;
import org.apache.synapse.commons.json.JsonUtil;
import org.apache.synapse.config.xml.SynapsePath;
Expand Down Expand Up @@ -553,16 +552,5 @@ public static void readInputFactoryProperties(XMLInputFactory inputFactory) {
}
inputFactory.setProperty(XMLInputFactory.SUPPORT_DTD, Boolean.FALSE);
inputFactory.setProperty(XMLInputFactory.IS_SUPPORTING_EXTERNAL_ENTITIES, Boolean.FALSE);
if (Boolean.parseBoolean(System.getProperty(SynapseConstants.ENABLE_DTD_FORCEFULLY))) {
inputFactory.setProperty(XMLInputFactory.SUPPORT_DTD, Boolean.TRUE);
log.warn("Support for DTDs is enabled forcefully. "
+ "This may lead to XXE vulnerabilities. Use with caution!");
}
if (Boolean.parseBoolean(
System.getProperty(SynapseConstants.ENABLE_EXTERNAL_ENTITY_FORCEFULLY))) {
inputFactory.setProperty(XMLInputFactory.IS_SUPPORTING_EXTERNAL_ENTITIES, Boolean.TRUE);
log.warn("Support for External Entities is enabled forcefully."
+ " This may lead to XXE vulnerabilities. Use with caution!");
}
}
}
Loading