Change the destroy order of the components in the SynapseConfiguration #2419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajinieKavindya
force-pushed
the
graceful-shutdown-inbound-endpoint
branch
from
0f43cc4 to
df7f31c
Compare
| // destroy the Message Stores | ||
| for (MessageStore ms : messageStores.values()) { | ||
| if (ms instanceof AbstractMessageProcessor) { | ||
| ((AbstractMessageProcessor) ms).destroy(preserverState); |
There was a problem hiding this comment.
Don't we have any usage of preserverState?
There was a problem hiding this comment.
Here, it checks if a MessageStore instance is an instance of AbstractMessageProcessor, which is wrong IMO. Also, there is no destroy(preserverState) method in MessageStore.
SanojPunchihewa
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Ideally, the defined sequence and endpoints should be destroyed after the components who depend on them are destroyed.