Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Initial Data Fetching and Add Missing Credential Issuer Metadata Retrieval #533

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

gkatrakazas
Copy link
Member

Summary

This PR optimizes the data fetching strategy during the initial load by removing redundant calls to fetch VC and VP, which are already adequately handled on the home page upon login or signup. Additionally, it introduces the fetching of missing credential issuer metadata, ensuring comprehensive data availability and integrity from the start.

Changes

  • Removal of Redundant Data Fetching: The calls to get('/storage/vc') and get('/storage/vp') have been removed from the fetchInitialData function as these are already being called on the home page (/). This change eliminates unnecessary network requests during the initial data loading phase, thereby improving the loading performance and reducing data redundancy.
  • Addition of Credential Issuer Metadata Retrieval: Implemented a new feature in the fetchInitialData function to fetch credential issuer metadata for each issuer obtained from getExternalEntity('/issuer/all'). This ensures that all relevant metadata about issuers is readily available, filling a previously existing gap in our data fetching logic.

@gkatrakazas gkatrakazas requested a review from kkmanos February 25, 2025 11:13
@gkatrakazas gkatrakazas merged commit e7cb89c into master Feb 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants