Open
Conversation
Owner
|
At first look I think we should change a couple of things:
I also allowed test runs now to check code formatting and so on. |
Author
|
I will try to make it reusable My only problem was that the grid delgate needs to be passed to the last layer of your classes so it needed to be required in all of them It can't be optional since this is required in grid view But I will try to do it |
|
Any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i added grid support to the code
but i got a problem where the updated flicker
i think the code updates the widgets twice or the multiple list changes makes the ui not consistent