CP-52225: Misc improvements #3
Conversation
last-genius
force-pushed
the
private/asultanov/poll_improvement
branch
from
a2a64d6 to
172fcad
Compare
|
Added another cleanup commit |
|
Are there any limitations to the minimum supported version of OCaml imposed by the Xen project? Otherwise I'm happy to support 4.14 as the minimum |
|
Figured out some XenRT issues and re-testing this |
|
This is draft but has green ticks - merge it? |
|
no, I've discovered issues while testing and am figuring out a fix |
|
Please review the fixup commit - I've missed - try Poll.poll_select (spec_fds @ inset) outset [] timeout
+ try Poll.poll_select cons.poll_status timeoutso this required some workarounds. This is currently running BST+BVT and looks good (and confirmed manually to work). |
|
Passed Ring3 BST+BVT. |
last-genius
force-pushed
the
private/asultanov/poll_improvement
branch
from
af9b41a to
9e792c4
Compare
last-genius
force-pushed
the
private/asultanov/poll_improvement
branch
2 times, most recently
from
86ff9e1 to
23f618b
Compare
|
Fixed the merge conflict. @edwintorok could you please let me know if there's anything blocking on your side or if the remaining comments are just suggestions? I haven't seen the discussed functions take up a significant amount of samples in flamegraphs so didn't undertake any further microoptimizations here. |
last-genius
force-pushed
the
private/asultanov/poll_improvement
branch
2 times, most recently
from
2cc1805 to
7ecc609
Compare
|
Testing the latest changes - looks like something is broken.... |
last-genius
force-pushed
the
private/asultanov/poll_improvement
branch
from
7ecc609 to
2cc1805
Compare
|
Spent most of the day debugging the issues last optimizations (not allocating a new event every time) introduced to no avail, so I'm reverting them back. Current version looks good in BST+BVT |
No need to maintain interface compatibility with select anymore, allocate an array of connection's poll status and modify that instead of allocating an array, three lists, and a hash table on each iteration of the main listening loop. Signed-off-by: Andrii Sultanov <[email protected]>
Signed-off-by: Frediano Ziglio <[email protected]>
String.fold_left and String.starts_with are available since OCaml 4.13 Signed-off-by: Andrii Sultanov <[email protected]>
last-genius
force-pushed
the
private/asultanov/poll_improvement
branch
from
2cc1805 to
7064d59
Compare
|
BST+BVT passed, squashed the fixup, merging. |
CP-52225 - poll: Reduce unnecessary allocations
No need to maintain interface compatibility with select anymore,
allocate an array of connection's poll status and modify that instead of
allocating an array, three lists, and a hash table on each iteration of
the main listening loop.
poll_select optimizations remove 10% of samples from the entire xenstore loop during a stress-test at creating 512 VMs: