Skip to content

CP-53478: Implement SSH-related APIs for Dom0 SSH control #6394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2025
Merged

CP-53478: Implement SSH-related APIs for Dom0 SSH control #6394

merged 3 commits into from
Apr 8, 2025

Conversation

LunfanZhang
Copy link
Contributor

Implemented XAPI APIs:

  • set_ssh_enabled_timeout
  • set_console_idle_timeout

These APIs allow XAPI to configure timeouts for the SSH service and idle console sessions from both host and pool level.

Updated records.ml to support host-param-set/get/list and pool-param-set/get/list for SSH-related fields.

@LunfanZhang LunfanZhang force-pushed the private/lunfan/CP-53478 branch from 2b4cf41 to 38b776b Compare March 31, 2025 08:21
BengangY
BengangY reviewed Mar 31, 2025
View reviewed changes
lindig
lindig approved these changes Mar 31, 2025
View reviewed changes
@robhoes
Copy link
Member

robhoes commented Mar 31, 2025

Please get used to splitting things up into separate commits. In this case you could easily have one commit for each API.

@LunfanZhang LunfanZhang force-pushed the private/lunfan/CP-53478 branch from 38b776b to e157273 Compare April 1, 2025 07:09
@LunfanZhang
Copy link
Contributor Author

Please get used to splitting things up into separate commits. In this case you could easily have one commit for each API.

I split it into three commits, including both API changes and one CLI change. I believe it's clearer now.

@LunfanZhang LunfanZhang requested review from robhoes and BengangY April 1, 2025 07:31
@LunfanZhang LunfanZhang force-pushed the private/lunfan/CP-53478 branch 2 times, most recently from 137eebb to 7259d11 Compare April 2, 2025 03:31
gangj
gangj reviewed Apr 2, 2025
View reviewed changes
@gangj
Copy link
Contributor

gangj commented Apr 2, 2025 •
edited
Loading

The first commit msg:

Implemented XAPI APIs:
  - `set_console_idle_timeout`

This API allow XAPI to configure timeouts for the idle console sessions.

->

Implemented XAPI APIs:
  - `host.set_console_idle_timeout`
  - `pool.set_console_idle_timeout`

These APIs allow XAPI to configure timeout for idle console sessions.

For 2nd one:

Implemented XAPI API:
  - `set_ssh_enabled_timeout`
This API allow XAPI to configure timeouts for the SSH service.

->

Implemented XAPI APIs:
  - `host.set_ssh_enabled_timeout`
  - `pool.set_ssh_enabled_timeout`
These APIs allow XAPI to configure timeout for SSH service.

And would be good to also mentioning that host.enable_ssh and host.disable_ssh are updated to support "ssh_enabled_timeout"

gangj
gangj reviewed Apr 2, 2025
View reviewed changes
gangj
gangj reviewed Apr 2, 2025
View reviewed changes
gangj
gangj reviewed Apr 2, 2025
View reviewed changes
gangj
gangj reviewed Apr 2, 2025
View reviewed changes
gangj
gangj reviewed Apr 2, 2025
View reviewed changes
@LunfanZhang LunfanZhang force-pushed the private/lunfan/CP-53478 branch 2 times, most recently from 4029de2 to 85bd7a0 Compare April 2, 2025 08:35
robhoes
robhoes requested changes Apr 4, 2025
View reviewed changes
@LunfanZhang LunfanZhang force-pushed the private/lunfan/CP-53478 branch from 85bd7a0 to b2b4db4 Compare April 7, 2025 07:25
@LunfanZhang LunfanZhang requested a review from robhoes April 7, 2025 07:46
@LunfanZhang LunfanZhang force-pushed the private/lunfan/CP-53478 branch from b2b4db4 to 5b0a968 Compare April 7, 2025 07:56
gangj
gangj reviewed Apr 7, 2025
View reviewed changes
gangj
gangj reviewed Apr 7, 2025
View reviewed changes
@LunfanZhang LunfanZhang force-pushed the private/lunfan/CP-53478 branch from 5b0a968 to 5e07144 Compare April 7, 2025 08:37
@LunfanZhang LunfanZhang force-pushed the private/lunfan/CP-53478 branch from 5e07144 to ae090a6 Compare April 7, 2025 08:51
@LunfanZhang LunfanZhang force-pushed the private/lunfan/CP-53478 branch 2 times, most recently from 55ab0b0 to f92711d Compare April 7, 2025 09:17
@changlei-li changlei-li mentioned this pull request Apr 7, 2025
Merged
robhoes
robhoes approved these changes Apr 7, 2025
View reviewed changes
@LunfanZhang
CP-53723 Implement Console timeout configure API for Dom0 SSH control
f67dcf7 
Implemented XAPI APIs:
  - `host.set_console_idle_timeout`
  - `pool.set_console_idle_timeout`

These APIs allow XAPI to configure timeout for idle console sessions.

Signed-off-by: Lunfan Zhang <[email protected]>
@LunfanZhang
CP-53478: Implement SSH enabeld timeout API for Dom0 SSH control
a3bc84d 
Implemented XAPI APIs:
  - `host.set_ssh_enabled_timeout`
  - `pool.set_ssh_enabled_timeout`
These APIs allow XAPI to configure timeout for SSH service.
`host.enable_ssh` now also supports enabling the SSH service with a ssh_enabled_timeout

Signed-off-by: Lunfan Zhang <[email protected]>
@LunfanZhang
CP-53725 Create SSH-related xe CLI for Dom0 SSH control
cb9277d 
Updated `records.ml` file to support `host-param-set/get/list` and `pool-param-set/get/list` for SSH-related fields.

Signed-off-by: Lunfan Zhang <[email protected]>
@LunfanZhang LunfanZhang force-pushed the private/lunfan/CP-53478 branch from f92711d to cb9277d Compare April 8, 2025 02:31
@minglumlu minglumlu merged commit e29eda2 into xapi-project:feature/configure-ssh-phase2 Apr 8, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robhoes robhoes robhoes approved these changes

@lindig lindig lindig approved these changes

@gangj gangj gangj left review comments

@BengangY BengangY Awaiting requested review from BengangY

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LunfanZhang @robhoes @gangj @lindig @BengangY @minglumlu