CP-311860: pool.join: sync ldaps status with pool coordinator#6986
Open
liulinC wants to merge 2 commits intoxapi-project:feature/ldapsfrom
Open
CP-311860: pool.join: sync ldaps status with pool coordinator#6986liulinC wants to merge 2 commits intoxapi-project:feature/ldapsfrom
liulinC wants to merge 2 commits intoxapi-project:feature/ldapsfrom
Conversation
added 2 commits
March 31, 2026 08:25
During pool join, if both joining host and the pool joined the same domain, pre-check is passed and the joining host is permitted to join the pool. However, the ldaps status needs to be synced during pool join to keep pool consistent. Note: certificates will be synced during the pool join, so no need to worry about the ldaps certificates. Signed-off-by: Lin Liu <lin.liu01@citrix.com>
Signed-off-by: Lin Liu <lin.liu01@citrix.com>
liulinC
force-pushed
the
private/linl/postjoin
branch
from
eeae75b to
89ab708
Compare
lindig
approved these changes
Mar 31, 2026
| ~doc:"The certificates are invalid to setup TLS connection to Windows AD." | ||
| () ; | ||
| error Api_errors.auth_no_certs ["message"] | ||
| ~doc:"No certificates found to setup TLS connection to Windows AD" () ; |
Contributor
There was a problem hiding this comment.
…to set up a TLS connection… (not sure Windows needs to be mentioned, would rather spell out Active Directory).
| ignore_error ~msg:"Failed to sync ldaps status with pool coordinator" | ||
| ~warn: | ||
| "Error whilst syncing ldaps status with pool coordinator. The \ | ||
| pool-join operation will continue as only pool coordinator is used \ |
Contributor
There was a problem hiding this comment.
…as only the pool coordinator…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During pool join, if both joining host and the pool joined the same domain, pre-check is passed and the joining host is permitted to join the pool.
However, the ldaps status needs to be synced during pool join to keep pool consistent.
Note: certificates will be synced during the pool join, so no need to worry about the ldaps certificates.