CA-413431: filter OpaqueRef:NULL case #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exception, if one driver has no selected variant, and we want to select a variant for this driver Signed-off-by: Chunjie Zhu <[email protected]>
|
@stephenchengCloud @liulinC @rosslagerwall Could you please review the change? |
BengangY
approved these changes
Jul 11, 2025
BengangY
reviewed
Jul 11, 2025
| @classmethod | ||
| def GetSelectedDriverVariantUUID(cls, driver): | ||
| variantRef = driver.selected_variant(None) | ||
| if variantRef is None: |
There was a problem hiding this comment.
We can merge these 2 if conditions as they are the same None case.
DeliZhangX
approved these changes
Jul 15, 2025
stephenchengCloud
approved these changes
Jul 15, 2025
rosslagerwall
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exception, if one driver has no selected variant, and we want to
select a variant for this driver
we cannot pass OpaqueRef:NULL to XenAPI get_record function