Merge feature/host-network-device-ordering to master #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new proposed change in networkd will replace the interface-rename functionality to order the network devices. The result of the ordering performed by interface-rename is to rename the devices like eth0, eth1, etc. The new change in networkd will not rename the devices any more. Consequently, the use of hard-coded eth<N> in network reset in xsconsole should be eliminated to cope with the new change. Additionally, the new networkd replacing the interface rename functionality will perform the network reset with xapi together. The interface rename functionality will be deprecated in the future. Signed-off-by: Ming Lu <[email protected]>
The issue is the "MANAGEMENT_INTERFACE" in /etc/xensource-inventory is not cleared in a networking reset. While the networkd is still trying to read the value of "MANAGEMENT_INTERFACE" as the bridge name. This caused the new network interface was added into the bridge before reset. Signed-off-by: Ming Lu <[email protected]>
Signed-off-by: Ming Lu <[email protected]>
Signed-off-by: Ming Lu <[email protected]>
rosslagerwall
approved these changes
Nov 3, 2025
BengangY
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.