Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DashTree] Changes to parsing values from "Role" tag #1771

Merged
merged 2 commits into from
Feb 19, 2025
Merged

[DashTree] Changes to parsing values from "Role" tag #1771

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da582f1
[DashTree] Role tag, disabled "subtitle", "caption" uses
CastagnaIT Jan 30, 2025
17dc43b
[DashTree] Role tag, deprecated custom "forced" support
CastagnaIT Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/parser/DASHTree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,13 +466,23 @@ void adaptive::CDashTree::ParseTagAdaptationSet(pugi::xml_node nodeAdp, PLAYLIST

if (schemeIdUri == "urn:mpeg:dash:role:2011")
{
if (value == "subtitle")
contentType = "text";
else if (value == "forced") // ISA custom attribute
//! @todo: If no complains, remove commented lines on Kodi 23
// if ((value == "subtitle" || value == "caption") && contentType.empty())
// contentType = "text";

//! @todo: Remove custom "forced" value support on Kodi 23
if (value == "forced") // ISA custom attribute
{
LOG::LogF(LOGWARNING, "The support for the custom \"forced\" value on \"Role\" tag is now "
"deprecated, it will be removed on Kodi v23.\n"
"Please use the \"forced-subtitle\" standard value.");
adpSet->SetIsForced(true);
}
else if (value == "forced-subtitle")
adpSet->SetIsForced(true);
else if (value == "main")
adpSet->SetIsDefault(true);
else if (value == "caption" || value == "alternate" || value == "commentary")
else if (value == "alternate" || value == "commentary")
adpSet->SetIsImpaired(true);
}
}
Expand Down
Loading