-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement an iterative Poisson solver #69
Draft
pbartholomew08
wants to merge
116
commits into
xcompact3d:main
Choose a base branch
from
pbartholomew08:44-poisson-solver-iterative-solver
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Implement an iterative Poisson solver #69
pbartholomew08
wants to merge
116
commits into
xcompact3d:main
from
pbartholomew08:44-poisson-solver-iterative-solver
+2,085
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7223542
to
60b2726
Compare
Still to be tested in parallel
3025e76
to
9383258
Compare
9383258
to
824c631
Compare
This will disable iterative solver support
The high-order operator is implemented entirely in x3d2 code, the low-order (preconditioner) requires PETSc - therefore we should at least ensure the high-order operator is always tested
Currently this only supports BC_PERIODIC (however in principle any should be supported)
A few odd indentation results we killed - potentially due to long lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off the Poisson branch #32 and adds the interface to PETSc as an alternative Poisson solver.