Implement ping manager #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzzammilshahid
force-pushed
the
ping-manager
branch
2 times, most recently
from
33ea51e to
e3df152
Compare
|
Thinking a bit more about it. We need to remove the use of interface all together. The design of this library should only be to allow calling functions at specific time. What happens in those functions is the decision of the developers using the library. Instead of using |
|
This naturally means that any reference to the word "Pinger" in this library becomes wrong |
om26er
reviewed
Jul 19, 2024
workerpool.go
Outdated
|
|
||
| type wpConfig struct { | ||
| interval time.Duration | ||
| dataFunc func() []byte |
There was a problem hiding this comment.
Suggested change
| dataFunc func() []byte | |
| callback func() error |
muzzammilshahid
force-pushed
the
ping-manager
branch
from
6201405 to
34d2c76
Compare
om26er
reviewed
Jul 19, 2024
workerpool.go
Outdated
|
|
||
| type wpConfig struct { | ||
| interval time.Duration | ||
| callback func() []byte |
There was a problem hiding this comment.
Suggested change
| callback func() []byte | |
| callback func() error |
muzzammilshahid
force-pushed
the
ping-manager
branch
2 times, most recently
from
5140cf1 to
fd32693
Compare
muzzammilshahid
force-pushed
the
ping-manager
branch
from
fd32693 to
30e2fe1
Compare
om26er
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.