Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests]: Context and Sequence Parallel #438

Merged
merged 4 commits into from
Jan 20, 2025
Merged

[Tests]: Context and Sequence Parallel #438

merged 4 commits into from
Jan 20, 2025

Conversation

antferdom
Copy link
Contributor

Guarantee distributed inference integrity with newer xFuser versions (e.g. world_size -> dit_parallel_size) and gather benchmarking results. ParaAttention testing is our main reference.

@antferdom
Copy link
Contributor Author

@feifeibear @xibosun

feifeibear
feifeibear requested changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@feifeibear feifeibear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the MR! I suggest to change names of some files.

tests/context_parallel/debug_tests.py
@@ -0,0 +1,18 @@
import os
import sys
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run_test_diffusers_adapter.py

http-service/load_test.sh
@@ -0,0 +1,6 @@
HOST=127.0.0.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change name to run_test_clinet.sh?

tests/context_parallel/debug_flux_usp_example.py
@@ -0,0 +1,44 @@
import os
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

launch_flux_usp_service_example.py?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, these were temporal scripts meant for debugging, thus we can directly remove it. Or we can keep it as a blueprint for debugging.

@feifeibear feifeibear merged commit 251a7ba into xdit-project:main Jan 20, 2025
1 of 3 checks passed
@antferdom
Copy link
Contributor Author

Thanks for the MR! I suggest to change names of some files.

Before merging I wanted to have feedback about adding tests covering all the models supported by xDiT. What do you think?

@feifeibear
Copy link
Collaborator

Thanks for the MR! I suggest to change names of some files.

Before merging I wanted to have feedback about adding tests covering all the models supported by xDiT. What do you think?

Thank you for your thoughtful consideration. I certainly hope you can cover as many model services as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feifeibear feifeibear feifeibear requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antferdom @feifeibear