Handle neighbour requests in xdp-filter #474
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In deny-all mode xdp-filter breaks connectivity because it ends up dropping ARP packets. Add parsing of ARP packets and run the src/target IP of the ARP request/response through the same IP filter rules as the IP packets themselves. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
Like with ARP packets for IPv4, make sure we pass neighbour solicitations and advertisements through the filter rules for IPv6, to avoid connectivity breaking in deny-all mode. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using IP filter mode in xdp-filter, we don't parse neighbour requests (ARP
for IPv4, ND ICMPv6 packets for IPv6), which can lead to loss of connectivity in
deny-default mode. Add parsing of both types of neighbour packets and pass them
through the requisite filters.