Fix memory leak on WebViewController

xendit · Dec 24, 2024 · d50b526 · d50b526
1 parent dc8b5bd
commit d50b526
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Sources/Xendit/WebViewController/AuthenticationWebviewController.swift b/Sources/Xendit/WebViewController/AuthenticationWebviewController.swift
@@ -19,8 +19,8 @@ class AuthenticationProvider: AuthenticationProviderProtocol {
     func authenticate(fromViewController: UIViewController, URL: String, authentication: XenditAuthentication, completion: @escaping (XenditAuthentication?, XenditError?) -> Void) {
         let webViewController = AuthenticationWebViewController(URL: URL)
         webViewController.authentication = authentication
-        webViewController.authenticateCompletion = { updatedAuthentication, error in
-            webViewController.dismiss(animated: true, completion: nil)
+        webViewController.authenticateCompletion = { [weak webViewController] updatedAuthentication, error in
+            webViewController?.dismiss(animated: true, completion: nil)
             completion(updatedAuthentication, error)
         }
         DispatchQueue.main.async {

diff --git a/Sources/Xendit/WebViewController/WebViewController.swift b/Sources/Xendit/WebViewController/WebViewController.swift
@@ -20,8 +20,8 @@ class CardAuthenticationProvider: CardAuthenticationProviderProtocol {
         let webViewController = WebViewController(URL: URL)
 
         webViewController.token = authenticatedToken
-        webViewController.authenticateCompletion = { (token, error) -> Void in
-            webViewController.dismiss(animated: true, completion: nil)
+        webViewController.authenticateCompletion = { [weak webViewController] (token, error) -> Void in
+            webViewController?.dismiss(animated: true, completion: nil)
             guard error == nil else {
                 return completion(nil, error)
             }