XEOK-146 Use isSceneModelEntity instead of instanceOf SceneModelEntity

xeokit · Nov 19, 2024 · 744af0e · 744af0e
1 parent 0c7fcc8
commit 744af0e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/src/viewer/scene/marker/Marker.js b/src/viewer/scene/marker/Marker.js
@@ -212,7 +212,7 @@ class Marker extends Component {
         }
         this._entity = entity;
         if (this._entity) {
-            if (this._entity instanceof SceneModelEntity) {
+            if (this._entity.isSceneModelEntity) {
                 this._onEntityModelDestroyed = this._entity.model.on("destroyed", () => { // SceneModelEntity does not fire events, and cannot exist beyond its VBOSceneModel
                     this._entity = null; // Marker now may become visible, if it was synched to invisible Entity
                     this._onEntityModelDestroyed = null;

diff --git a/src/viewer/scene/model/SceneModelEntity.js b/src/viewer/scene/model/SceneModelEntity.js
@@ -34,6 +34,11 @@ export class SceneModelEntity {
          */
         this.model = model;
 
+        /**
+         * Identifies if it's a SceneModelEntity
+         */
+        this.isSceneModelEntity = true;
+
         /**
          * The {@link SceneModelMesh}es belonging to this SceneModelEntity.
          *

diff --git a/types/viewer/scene/models/SceneModelEntity.d.ts b/types/viewer/scene/models/SceneModelEntity.d.ts
@@ -411,6 +411,12 @@ export declare abstract class SceneModelEntity implements Entity {
      */
     meshes : SceneModelMesh[];
 
+
+    /**
+     * Identifies if it's a SceneModelEntity
+     */
+    isSceneModelEntity: boolean;
+
     /**
      * Destroys this SceneModelEntity.
      */