Change some traits' associated types to type parameters#39
Open
Bubbler-4 wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guessing from the technical note for
WidthHeuristic, all traits that don't directly define the problem are designed to be problem-agnostic, and should be written using type parameters instead of associated types.This PR changes the traits
DecisionDiagram,Fringe,Cache,DominanceChecker, andSubProblemRankingto use type parameters instead of associated types. The former three are obviously part of the "engine"; the other two act as wrappers for user-implemented traitsDominanceandStateRankingrespectively, and therefore can be considered problem-agnostic as well. All examples compiled and example tests passed without modification.I'm working on generalizing
Solutionto allow types other thanVec<Decision>, includingDecisions, to avoid duplicationand this PR is expected to make the change a bit cleaner.