-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A first draft of an Atom syndication format plugin. #43
Conversation
cc @xhtmlboi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what would be great is :
- Have Rss support in
yocaml_syndication
- Have a hook that converts the metadata (Articles) to a feed, similar to how it is done in YOCaml.
Anyway, thank you very much for this contribution and sorry for the delay!
I would have liked to but I am stuck by the lack of function for output a |
You are right Cumulus/Syndic#75 |
It seems that the current branch does not typecheck.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small fix (and after I can merge)
Oops. I also added a link to the syndic library in the doc. |
Fix #42 for posterity, I guess 😛 |
Thanks a lot! |
We discussed it here so here is a first try with several weaknesses:
I tried as much as possible to have an API similar to
Yocaml.Rss
but I didn't know if it was wise that the parameters that are URLs should beUri.t
or more naturallystring
.In
Atom.make
, the data used to creategenerator
parameter are hardcoded, they could be replaced by generating the yocaml.opam
file with dune and using watermarks replaced by dune.I don't know if the data such as
authors
must also be wrapped in their own data type to erasesyndic
tracesIn addition, I fixed a small detail
Format.printf "\"%s\"" str
can be replaced byFormat.printf "%S" str
.