fix: reduce darkreader mode white flash further by using QWebEnginePage::setBackgroundColor() (for Qt6.6.3+) #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyifang
reviewed
Feb 27, 2024
shenlebantongying
force-pushed
the
fix-white-flash-via-setbackground
branch
from
25b24ae to
9280d85
Compare
QWebEnginePage::setBackgroundColor() (for Qt6.6.3+) In previous Qt6.x versions, this function only set background once and become invalidated if reload a page.
xiaoyifang
reviewed
Feb 27, 2024
shenlebantongying
force-pushed
the
fix-white-flash-via-setbackground
branch
from
fb4e65b to
50eeab3
Compare
Repository owner
deleted a comment from
xiaoyifang
Feb 27, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is finally fixed
https://bugreports.qt.io/browse/QTBUG-112013
qt/qtwebengine@85bfaa5
This should ultimately eliminate the white flash in dark reader mode.
Related #357
(BTW, I am not sure what you did to reduce white flash previously at #357 (comment) which does work, but the bug still exists in Qt6.6.2 evidenced by my small demo https://github.com/SourceReviver/qtwebengine_bg_not_work .
Maybe the previous workarounds will be duplicated with this? Or they cover different phases of white flash. I don't know.)