Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: properly handle Unix signals, like SIGTERM, for graceful exit #1732

Merged
merged 7 commits into from
Aug 22, 2024

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented Aug 21, 2024

@shenlebantongying shenlebantongying changed the title feat: properly handle Unix SIGTERM, aka graceful exit feat: properly handle Unix signals, like SIGTERM for graceful exit Aug 21, 2024
@shenlebantongying shenlebantongying force-pushed the feat/UNIX_SIGNAL branch 2 times, most recently from c93b828 to 04d56ff Compare August 21, 2024 11:10
@shenlebantongying shenlebantongying changed the title feat: properly handle Unix signals, like SIGTERM for graceful exit feat: properly handle Unix signals, like SIGTERM, for graceful exit Aug 21, 2024
/*
SPDX-FileCopyrightText: 2021 Aleix Pol Gonzalez <[email protected]>

SPDX-License-Identifier: LGPL-2.1-or-later
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this license compatible with GPL3

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "LGPL-2.1-or-later" section 3 says

  1. You may opt to apply the terms of the ordinary GNU General Public License instead of this License to a given copy of the Library. To do this, you must alter all the notices that refer to this License, so that they refer to the ordinary GNU General Public License, version 2, instead of to this License. (If a newer version than version 2 of the ordinary GNU General Public License has appeared, then you can specify that version instead if you wish.) Do not make any other change in these notices.

And this footnote https://www.gnu.org/licenses/gpl-faq.en.html#compat-matrix-footnote-7 in GNU's FAQ

Based on the text, we should change this file's license to GPLv3, as allowed by "LGPL-2.1-or-later".

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@xiaoyifang xiaoyifang merged commit 3ca7c39 into xiaoyifang:staged Aug 22, 2024
7 of 8 checks passed
@shenlebantongying shenlebantongying deleted the feat/UNIX_SIGNAL branch August 28, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants