Partially revert "Enable application log" to "Log to file" #2118
Conversation
src/main.cc
Outdated
| // Install message handler | ||
| qInstallMessageHandler( gdMessageHandler ); | ||
| // Log to file enabled through command line or preference | ||
| if ( gdcl.logFile || cfg.preferences.enableApplicationLog ) { |
There was a problem hiding this comment.
If user set the option () through the preference , this line will never get the chance to run.
eg:
cfg.preferences.enableApplicationLog=false ,
then user set it through preference.
There was a problem hiding this comment.
Yes?
If the option is not enabled, the default message handler will be working (printing to stdio/console).
If the option is enabled, the custom message handler that prints to gd_log.txt will starts to work.
There was a problem hiding this comment.
The logFilePtr is useless if the option is not enabled.
There was a problem hiding this comment.
which means the option in the preference will only work in the next time?
There was a problem hiding this comment.
Ok, I know what you mean now, and I have decided to move this thing out of main.cc
shenlebantongying
force-pushed
the
rev/log
branch
from
b6587ec to
ad244b7
Compare
shenlebantongying
force-pushed
the
rev/log
branch
from
3bca7bb to
a281895
Compare
shenlebantongying
force-pushed
the
rev/log
branch
from
59ab7a1 to
657b886
Compare
|
|
before this commit , This function does not work now. maybe related with this commit . |
This is not what happened before this commit. Before this commit, there is no way to get console output. Now you just need to disable log-to-file for logging to console again. 
|
|
ok, seems introduced by me. :( |
Partially revert #2097
Problem: This is only useful for Windows where
Consoleis a none-trivial thing for the user to use.But for Linux, users are generally knows how to use terminal, and app writing messages to
stdiois common.The change in #2097 effectively disabled logging in terminal by default, which is confusing to Linux users.