Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean: replace QAbstractItemModel with more suitable QAbstractTableModel #2129

Merged

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented Feb 7, 2025

  • delete boilerplates (parent which is useless for 2 dimension data & index which can just have a fix implementation for 2 dimension data)
  • add override when overriding

The primary feature of QAbstractTableModel is implementing things that isn't needed by a table-like data, which is what we use.

Copy link

sonarqubecloud bot commented Feb 7, 2025

@shenlebantongying shenlebantongying merged commit d70ab6a into xiaoyifang:staged Feb 8, 2025
9 checks passed
@shenlebantongying shenlebantongying deleted the clean/del-abs-models branch February 8, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant