Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use configure_file for build time string data #2132

Merged

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented Feb 8, 2025

It's pretty standard.

The alternative is looking these data from build.ninja.

@shenlebantongying shenlebantongying enabled auto-merge (squash) February 8, 2025 02:43
@shenlebantongying shenlebantongying merged commit 05a19b1 into xiaoyifang:staged Feb 8, 2025
7 checks passed
@shenlebantongying shenlebantongying deleted the refactor/conf_file branch February 8, 2025 02:52
Copy link

sonarqubecloud bot commented Feb 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant