fix: revert "clean: reduce implicit int -> (q)sizetype conversion warnings (#2127)"

[shenlebantongying]

Revert #2127

potentially related

• Crash (SIGABRT/signal 6) on macOS 15.2 (24C101) #2113
• The compiled goldendict in Ubuntu 24.04 adds offline dictionary exception and cannot check words. #2152

Still not sure what's wrong, code looks correct.

But let's revert this fast, before it causes more errors.

[sonarqubecloud]

Quality Gate failed

Failed conditions
7.5% Duplication on New Code (required ≤ 3%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[xiaoyifang]

#2113 this issue may not caused by this.

As #2113 can also be reproduced by the previous release .

[shenlebantongying]

Just reproduced the error again with this dict's slob format.

https://github.com/latin-dict/Lewis1890/releases

The diff

diff.diff.zip

Part of it

--- ./a69267eaf8243dd2ae0c33ecddc2dce9
+++ ./a69267eaf8243dd2ae0c33ecddc2dce9_7bff0e1
@@ -50,16 +50,16 @@
 00000310: 23de 1419 953e c5f9 0624 54ee 6661 5478  #....>...$T.faTx
 00000320: cd62 8821 7793 da28 e4c5 0ef3 3ccd c9f8  .b.!w..(....<...
 00000330: b85f 1f12 074a e5a3 d80d 5d3f 9fa0 7bd1  ._...J....]?..{.
 00000340: 3f15 2a8c c4df 105f ec0c b7e7 9f6e 35c7  ?.*...._.....n5.
 00000350: 97bd a284 fe6d 1bd6 2239 42ff 417c 543a  .....m.."9B.A|T:
 00000360: 8848 fe9f 657f 1e21 2264 a6ab 36cf 4a2c  .H..e..!"d..6.J,
 00000370: 7640 83ff a5eb 534e 0879 7d6d a701 e39c  [email protected]}m....
-00000380: c94c 24fb 86c0 773c e6b7 418f 0300 0049  .L$...w<..A....I
-00000390: 0900 00a1 0300 0078 9c65 9669 d3d4 4410  .......x.e.i..D.
+00000380: c94c 24fb 86c0 773c e6b7 418f 0300 0000  .L$...w<..A.....
+00000390: 0000 00a1 0300 0078 9c65 9669 d3d4 4410  .......x.e.i..D.
 000003a0: c767 0111 1550 d117 16c5 9779 3eca 6c36  .g...P.....y>.l6
 000003b0: c533 5549 6699 245b e54b abb8 951b 543c  .3UIf.$[.K....T<
 000003c0: c00b f040 0e39 0515 39e5 5250 1005 4401  [email protected].
 000003d0: 0544 1405 0111 45fc 7727 99e9 142f b62a  .D....E.w'.../.*
 000003e0: fd4b dfd3 d3d9 6794 52e3 f01b 8aba da95  .K....g.R.......
 000003f0: b952 5321 8cc5 4f47 51dc b34a 4dc3 f3e3  .RS!..OGQ..JM...
 00000400: b59c c44e 1706 707a 6d45 3023 ad19 10c6  ...N..pzmE0#....
@@ -109,15 +109,15 @@
 000006c0: 4dcd ed3a 7f78 b198 6a5d 721e 7f83 3ccc  M..:.x..j]r...<.
 000006d0: 7a05 a43b 7ed2 0a9e e27f 7c13 2053 b9ff  z..;~.....|. S..
 000006e0: 4a40 99dc f5b9 1546 f3b4 fe17 7cf0 3cdf  [email protected]....|.<.
 000006f0: f347 c21b 4875 9a43 2c0c fd1f e874 823a  .G..Hu.C,....t.:
 00000700: 1dc5 0829 c37c 64c7 9bd3 b61a d569 ea2a  ...).|d......i.*
 00000710: 4aed a882 073a cd82 66c2 1faa d19d a6e1  J....:..f.......
 00000720: ccc8 cf83 c10f 8519 d369 1a56 9436 c7f2  .........i.V.6..
-00000730: 7808 e07f 4488 1435 3c07 0000 ed08 0000  x...D..5<.......
+00000730: 7808 e07f 4488 1435 3c07 0000 0000 0000  x...D..5<.......
 00000740: 4803 0000 789c 5d94 5777 db30 0c85 e9b7  H...x.].Ww.0....
 00000750: 9e26 4d9b 344d d3bd f7de 7ba4 7bef bd65  .&M.4M....{.{..e
 00000760: 89b6 d9ca b223 8b69 bad3 bdfb 9b7b 415a  .....#.i.....{AZ
 00000770: 009d 079f 637c 022e 2e20 8a53 4aa9 01fc  ....c|... .SJ...
 00000780: a2b8 b0ad 8eed 2835 b3a2 d448 9720 ecab  ......(5...H. ..
 00000790: f0df 7efc 9dd5 7d52 d826 0280 d90e d854  ..~...}R.&.....T
 000007a0: 472e 6780 7380 08cc 06e8 f7a0 a933 a5e6  G.g.s........3..
@@ -163,15 +163,15 @@
 00000a20: 1b7b cba3 1b5b 5ea6 efa4 8bcd bcf3 f7bd  .{...[^.........
 00000a30: 881a 7fe8 45d4 6f2a 5077 dfe3 4759 89a5  ....E.o*Pw..GY..
 00000a40: 6e9f 8298 4efa e7a0 c089 7e09 1c17 b999  n...N.....~.....
 00000a50: 54ea 6b98 424d be05 1a13 d0f8 ce09 6954  T.k.BM........iT
 00000a60: 258d 1fac e100 527e b2d5 348a 73b7 db5f  %.....R~..4.s.._
 00000a70: 4152 dbdd 97bf 039d 82aa fe04 55dd 43fb  AR..........U.C.
 00000a80: 5772 fc95 f60f e03f c26c bf26 900a 0000  Wr.....?.l.&....
-00000a90: 4e09 0000 5903 0000 789c 6596 e58e e330  N...Y...x.e....0
+00000a90: 0000 0000 5903 0000 789c 6596 e58e e330  ....Y...x.e....0
 00000aa0: 10c7 dd1c 2f83 4eba 0ff7 0af7 10fb 28b9  ..../.N.......(.
 00000ab0: d45a 596a 9d9e 9354 fbf5 9ee0 9899 9999  .ZYj...T........
 00000ac0: 9999 9999 9971 c66e c793 aeb4 2b75 7efd  .....q.n....+u~.
 00000ad0: cfcc df63 3be9 5821 443b fc87 c592 ec0d  ...c;.X!D;......
 00000ae0: 5315 0b31 ae20 c488 3a82 787c c17f 9e00  S..1. ..:.x|....
 00000af0: 9fbb 6adf 55c3 b2d4 6956 1662 62c1 17a9  ..j.U...iV.bb...
 00000b00: ba22 9300 b5d4 11c4 9321 6e75 b18a 5030  .".......!nu..P0

[shenlebantongying]

I still don't know what's wrong. The code change looks legit.