Skip to content

Commit

Permalink
Fix rendering of circle element added to a group
Browse files Browse the repository at this point in the history
  • Loading branch information
rubenberttpingol committed Jan 28, 2025
1 parent f4f6086 commit ac79b5d
Showing 1 changed file with 11 additions and 8 deletions.
19 changes: 11 additions & 8 deletions modules/src/xibo-player.js
Original file line number Diff line number Diff line change
Expand Up @@ -1445,9 +1445,18 @@ XiboPlayer.prototype.renderGlobalElements = function(currentWidget) {
$elementContentContainer,
);
}
});

// If there's a group content element
// Append it to the page
if ($groupContent) {
$content.append($groupContent);
}

// Invoke groupItem onTemplateRender if present
Promise.all(Array.from(elemObj.items).map(function(groupItem) {
const itemID =
groupItem.uniqueID || groupItem.templateData?.uniqueID;
groupItem.uniqueID || groupItem.templateData?.uniqueID;

// Call onTemplateRender
// Handle the rendering of the template
Expand All @@ -1459,13 +1468,7 @@ XiboPlayer.prototype.renderGlobalElements = function(currentWidget) {
{groupItem, ...groupItem.templateData, data: {}},
meta,
);
});

// If there's a group content element
// Append it to the page
if ($groupContent) {
$content.append($groupContent);
}
}));
}
} else {
// Single elements
Expand Down

0 comments on commit ac79b5d

Please sign in to comment.