Remove support for loading IMG, CCD, SUB files. #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested by malvarenga123: xjsxjs197#139 (comment) malvarenga123: To me that answer was really strange as the sub file is very small compared to the main image, so you shouldn't need to read it that frequently. What I think is more plausible is that the general reading routine (for all formats) is not really optimized and the constant access to USB or SD card is causing those stutters. xjsxjs197 already said that if using CCD/IMG/SUB, it causes many stutters not present on BIN/CUE, CHD, or other formats. xjsxjs197#139 (comment) Reduces DOL file size in 896 bytes.
|
Thank you very much for assisting with the modification, but due to some reasons, such as some people still using game files in these formats, they may find it troublesome to switch to other formats. So this correction will not be merged into the main branch temporarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the conversation in #139, and also since @xjsxjs197 agreed with removing support for IMG, CCD, SUB files on WiiStation, i worked in the past months trying to disable code for load these files.
Now the emulator will only allow loading BIN+CUE, CHD, and PBP.
(SBI file loading will be unaffected since it's needed for play LibCrypt games)
The size reduction is not big, but at least we had reduced the memory usage, i guess.