Skip to content

Make default menus behave consistently #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2025
Merged

Make default menus behave consistently #958

merged 2 commits into from
Nov 25, 2025

Conversation

@geekosaur
Copy link
Contributor

@geekosaur geekosaur commented Nov 25, 2025 •
edited
Loading

Description

Some *Menu functions defer to *MenuConfig, others to *MenuArgs def; the def there is the empty list, losing the default parameters passed to dmenu. I have not changed the deferrals since people may be relying on that, but I have replaced def with the default list of dmenu parameters (currently only "-i").

Also, since the default dmenu parameters needed to be shared to do the above, export it for users to use in *MenuArgs calls if they wish.

Checklist

  • I've read CONTRIBUTING.md

  • I've considered how to best test these changes (property, unit,
    manually, ...) and concluded: must be tested manually

  • I updated the CHANGES.md file

@geekosaur
Make default menus behave consistently
aca36a8 
Also, since the default dmenu parameters needed  to
be shared to make things consistent, export that shared
list of parameters for users to use in `*MenuArgs` calls.
@geekosaur geekosaur force-pushed the windowbringer-inconsistency branch from 5934821 to aca36a8 Compare November 25, 2025 02:14
@geekosaur geekosaur linked an issue Nov 25, 2025 that may be closed by this pull request
WindowBringer's gotoMenu and bringMenu are inconsistent with each other with respect to case insensitivity #956
Closed
@geekosaur geekosaur mentioned this pull request Nov 25, 2025
Closed
@geekosaur
Copy link
Contributor Author

geekosaur commented Nov 25, 2025 •
edited
Loading

An alternative way to do this would be to, instead of adding and using a common default for the arguments, use menuArgs def. But I still find def error-prone (#575, and arguably this bug since def was apparently expected to do that automatically here) and would strongly prefer to avoid its use.

@geekosaur geekosaur force-pushed the windowbringer-inconsistency branch from 4e8f175 to 2d69be3 Compare November 25, 2025 02:51
@geekosaur geekosaur marked this pull request as ready for review November 25, 2025 02:52
slotThe
slotThe approved these changes Nov 25, 2025
View reviewed changes
Copy link
Member

@slotThe slotThe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@geekosaur geekosaur force-pushed the windowbringer-inconsistency branch from 2d69be3 to 073b1de Compare November 25, 2025 18:01
@geekosaur geekosaur merged commit a068876 into xmonad:master Nov 25, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slotThe slotThe slotThe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WindowBringer's gotoMenu and bringMenu are inconsistent with each other with respect to case insensitivity

2 participants

@geekosaur @slotThe