fix: register codecs on create of clients in android #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
commented
Dec 15, 2023
| @@ -145,6 +145,7 @@ class XMTPModule : Module() { | |||
| signer = reactSigner | |||
| val options = ClientOptions(api = apiEnvironments(environment, appVersion)) | |||
| clients[address] = Client().create(account = reactSigner, options = options) | |||
| ContentJson.Companion | |||
There was a problem hiding this comment.
I'm not sure it's necessary to call Companion here it could be implicitly called without it. But I wanted to explicit that this is triggering the init function that registers the codecs.
alexrisch
approved these changes
Dec 15, 2023
|
🎉 This PR is included in version 1.22.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't registering the codecs in Android when creating the client which could cause issues with rendering codecs. This registers the codecs on client create