Messages with reactions function, dm fix #596
Conversation
|
| @@ -159,6 +177,18 @@ class ContentJson( | |||
| ) | |||
| ) | |||
|
|
|||
| ContentTypeReactionV2.id -> { | |||
| val reaction: FfiReaction = decodeReaction(encodedContent!!.toByteArray()) | |||
There was a problem hiding this comment.
reactionV2 in this PR mainly serves to show how proto based ContentTypes that are used in libxmtp and upstream xmtp-android/ios can be utilized in React Native.
In this PR, we're basically converting the proto type back to json before utilizing the Reaction content in RN typescript code. An alternative would be to send the reaction content as bytes over the RN bridge and deserialize the bytes to the Reaction proto object in typescript. This pattern would generally lead to less data going over the RN bridge and would probably be a net gain for pretty much all data classes we use. However, it probably makes sense to start implementing that pattern in a separate PR.
Lastly, in a follow up, we can delete the reactionV2Codec in RN, and simply update the ContentTypeId version from 1.0 to 2.0, and the underlying SDK will switch from using JSON serializing to proto serializing without RN integrators knowing the difference. One exception is that old clients will not be able to deserialize messages sent with the proto backed reactions, but they should recognize that the version has been updated, and display the fallback instead. maintaining the two different Reaction and ReactionV2 for a short while in RN will help us test those paths.
| @@ -0,0 +1,194 @@ | |||
| diff --git a/node_modules/react-native/sdks/hermes/hermes-engine.podspec b/node_modules/react-native/sdks/hermes/hermes-engine.podspec | |||
There was a problem hiding this comment.
See issue here on incorrect checksum error for boost dependency. Only affects our RN example app - facebook/react-native#42180
| @@ -1,10 +1,15 @@ | |||
| { | |||
| "$schema": "https://unpkg.com/@changesets/[email protected]/schema.json", | |||
| "changelog": "@changesets/cli/changelog", | |||
| "changelog": [ | |||
There was a problem hiding this comment.
the documentation isnt super clear on this, but hoping this will fix our changesets not creating github release / tag.
| action = getReactionV2Action(reaction.get("action").asString.lowercase()), | ||
| schema = getReactionV2Schema(reaction.get("schema").asString.lowercase()), | ||
| content = reaction.get("content").asString, | ||
| referenceInboxId = "" |
There was a problem hiding this comment.
Question: is that intentional left empty?
There was a problem hiding this comment.
yea that property is sort of stubbed in for now, as I noticed it was included in the xmtp-js reaction type: https://github.com/xmtp/xmtp-js/blob/80aa5ec4fb24b60def222537cebcb20c818ca993/content-types/content-type-reaction/src/Reaction.ts#L24
However xmtp-react-native has an existing ReactionContent type that didn't feel worth updating at this point since I'm not sure what referenceInboxId would actually be used for.
definitely a code smell though, I added a clarifying comments here 👌: faad8de
|
To do: