-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terraform README #13
Terraform README #13
Conversation
messages_contract_address = "0x162f2d4d96565437F47bfB7a0BF8AC4FF481Bbf6" | ||
identity_updates_contract_address = "0x00e92e15AB0D7d3aA5c76bceCcE675DcAf311189" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these the "final" ones? Can I copy them over to the Helm README?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're the ones in use in our current testnet. You can copy over for now, although we should come up with a central place to hold these values so we only have to update one place instead of 6 when we eventually rewrite these contracts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could adopt a proxy + create2 approach for contract deployments.
Making the contracts upgradable through a proxy would guarantee that, once deployed, the address won't ever change.
CREATE2 is a optional; it's an EVM opcode that would give us the capability of predicting the address where a contract is going to be deployed by using a salt. This could be used in the future if we consider migrating between blockchains and would want to preserve the address for some reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that idea. We would still need to update some config if the shape of the events ever changed, since the ABI parsing lives in the code and would need to be updated at the same time.
But most contract changes don't change the event structure.
terraform/README.md
Outdated
3. In Terraform Cloud make sure the `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` environment variables are set to the credentials for your Terraform IAM user | ||
4. `terraform init` (you may need to run `terraform login` first if you have never used the Terraform CLI before) | ||
5. `terraform apply` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend to do terraform plan
"and review the plan" before running apply.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. That is more prudent.
a3fdc9e
to
ff80a9a
Compare
TL;DR
Added comprehensive documentation for deploying XMTPD nodes using Terraform on AWS.
What changed?
How to test?
terraform init
andterraform apply
to verify deploymentWhy make this change?
To provide clear, step-by-step instructions for users wanting to deploy XMTPD nodes on AWS infrastructure, making the deployment process more accessible and reducing potential setup errors.