Proxy #25
Proxy #25
Conversation
There was a problem hiding this comment.
As it stands I just don't understand this design pattern. Also your example of auth being coupled with a cart being emptied is super odd. Who would ever do this?
Suggest reworking this doc so first time readers can "get it". I am a first time reader, and I don't.
| private func checkIfAuthenticated() -> Bool { | ||
| return false | ||
| } |
There was a problem hiding this comment.
This doesn't make sense. Why return false in this method. In example code its perfectly legitimate to use comments to explain what a method might do and not add all the code. So // fetch authentication state here.
|
|
||
| ## Domain application | ||
| - The proxy pattern allows us to separate the analytics logic from the `Bag` class, conforming to the single responsibility principle. |
There was a problem hiding this comment.
adhering to, not conforming to. Use conforming for objects which conform to protocols.
| logAnalyticsEvent(with: "allProductsRemovedFromBag") | ||
| } | ||
|
|
||
| private func logAnalyticsEvent(with id: String) { |
There was a problem hiding this comment.
One of the sections in API Guidelines is title: "Compensate for weak type information to clarify a parameter’s role"
Read it again.
The call site of this method reads: logAnalyticsEvent(with: {someStringGoesHere}. How is the consumer supposed to know what that String needs to be. Should it be a description, an ID, or something else.
In cases where argument labels are prepositions (with, for, etc) and the TYPE is a basic like String, Int, AnyObject, it helps the reader to append more info to the preposition to make the call site clearer.
So in this case it should read withID id: String
Note: another approach is to create an explicit type like UserID, or just create a typealias: typealias ID = String. This way the type communicates to consumers what needs to be passed in, and your method can take the form: user(with id: ID).
There was a problem hiding this comment.
Tempted to go with the typealias, but withID id: String is better for the reader
| - Common uses include controlling access to a class, adding logging, or to add caching. | ||
| - It is often used in situations where you want to add behavior to a class without changing the class itself. | ||
|
|
||
| - It is used in situations where you want to add behavior to a class without changing the class itself. |
|
|
||
| - The object that we want to add behavior to. | ||
|
|
||
| - In our scenario, this is an existing `Bag` class that we would like add analytics to. |
No description provided.