Feature/clang format #629
Merged
Feature/clang format #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serge-sans-paille
force-pushed
the
feature/clang-format
branch
5 times, most recently
from
c1db9da to
0752b19
Compare
serge-sans-paille
force-pushed
the
feature/clang-format
branch
from
0752b19 to
f9cd681
Compare
JohanMabille
reviewed
Nov 4, 2021
CONTRIBUTING.md
Outdated
| @@ -0,0 +1,25 @@ | |||
| # Contributing to xsimd | |||
|
|
|||
| First, thanks for being there! Welcome on board, We'll try to make your | |||
There was a problem hiding this comment.
"We'll try to make your" => "we will try to make your"
CONTRIBUTING.md
Outdated
| # Submitting patches | ||
|
|
||
| Patches should be submitted through Github PR. We put some effort to setup a | ||
| decent Contibuous Integration coverage, please try to make it green ;-) |
CONTRIBUTING.md
Outdated
| Patches should be submitted through Github PR. We put some effort to setup a | ||
| decent Contibuous Integration coverage, please try to make it green ;-) | ||
|
|
||
| We're using [clang-format](https://clang.llvm.org/docs/ClangFormat.html) to keep |
There was a problem hiding this comment.
"We're using" => "We are using"
CONTRIBUTING.md
Outdated
|
|
||
| # Extending the API | ||
|
|
||
| We're open to extending the API, as long as it has been discussed either in an |
There was a problem hiding this comment.
"We're open" => "We are open"
serge-sans-paille
force-pushed
the
feature/clang-format
branch
from
f9cd681 to
aa1d91a
Compare
|
The appveyor failure is due to a manual cancellation: since this PR was opened from a branch of this repo (not a fork), this triggered two builds from appveyor, one for the branch and on for the PR. However, these two builds are actually the same, so no need to waste time and resources on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.