Skip to content

Commit

Permalink
refactor(underglow): allow full range for initial brightness
Browse files Browse the repository at this point in the history
The brightness is already scaled within zmk_rgb_underglow_tick(). With the
current range condition, setting max brightness to 20% results in starting with
4% (20% of 20%) brightness.
  • Loading branch information
xudongzheng committed Jan 21, 2025
1 parent db2fc2b commit 96dbea4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ config ZMK_RGB_UNDERGLOW_SAT_START

config ZMK_RGB_UNDERGLOW_BRT_START
int "RGB underglow start brightness value in percent"
range ZMK_RGB_UNDERGLOW_BRT_MIN ZMK_RGB_UNDERGLOW_BRT_MAX
range 0 100

config ZMK_RGB_UNDERGLOW_SPD_START
int "RGB underglow start animation speed value"
Expand Down
4 changes: 2 additions & 2 deletions app/Kconfig.defaults
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ config ZMK_RGB_UNDERGLOW_SAT_START
default 100

config ZMK_RGB_UNDERGLOW_BRT_START
default ZMK_RGB_UNDERGLOW_BRT_MAX
default 100

config ZMK_RGB_UNDERGLOW_SPD_START
default 3
Expand Down Expand Up @@ -80,4 +80,4 @@ config ZMK_BATTERY_REPORT_INTERVAL
default 60

# Imports
rsource "src/split/Kconfig.defaults"
rsource "src/split/Kconfig.defaults"

0 comments on commit 96dbea4

Please sign in to comment.