Add gauge increment/decrement shorthands#13
Merged
Envek merged 5 commits intoyabeda-rb:masterfrom Aug 7, 2020
Merged
Conversation
Envek
requested changes
Aug 6, 2020
spec/yabeda/gauge_spec.rb
Outdated
| context "when gauge has no initial value" do | ||
| before { gauge.increment(tags) } | ||
|
|
||
| it { expect(gauge.get(tags)).to eq 1 } |
Member
There was a problem hiding this comment.
IMO correct way to test it would be checking that adapters have received this value:
Suggested change
| it { expect(gauge.get(tags)).to eq 1 } | |
| it { gauge.increment(tags) expect(adapter).to have_received(:perform_gauge_set!).with(gauge, tags, 1) } |
Member
Author
|
it's done |
Envek
approved these changes
Aug 7, 2020
Envek
added a commit
that referenced
this pull request
Aug 7, 2020
Member
|
Released in 0.7.0. Thank you! |
tanaka0722-dev
added a commit
to tanaka0722-dev/yabeda
that referenced
this pull request
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.